Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16675 )
Change subject: KUDU-3210 Disable digest authn in FIPS mode ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc@280 PS5, Line 280: CHECK(!FIPS_mode()) > Seems that would stop the server from starting too, but the ASSERT_DEATH wo I thought about a couple of things: * Exiting a process with non-zero exit code might be preferable because leaving behind core files in situations like this doesn't make much sense: it's enough to output an error message into the log: less disk space consumed, especially if core dump is enabled. From this perspective, aborting a process is a last resort when it's not possible to resolve the inconsistency of the run-time state by other means and continuing running might cause even more damage. * In some cases, it make sense to give the upper level code a choice to handle this (i.e., just disable the webserver and proceed with the start process). It's up to you: if there is a reason to crash right here but not exit with non-zero code, this is fine with me. As for the test, there is {ASSERT,EXPECT}_EXIT() as an alternative to {ASSERT,EXPECT}_DEATH() if you found that the process just exits with non-zero status instead of crashing. -- To view, visit http://gerrit.cloudera.org:8080/16675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a446aa8d95a67658c727d3a6f85943d64c79ecf Gerrit-Change-Number: 16675 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 20:16:34 +0000 Gerrit-HasComments: Yes
