Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/16675 )
Change subject: KUDU-3210 Disable digest authn in FIPS mode ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/16675/5/src/kudu/server/webserver.cc@280 PS5, Line 280: CHECK(!FIPS_mode()) > As an option, what if the code returned State::IllegalState() from here -- Seems that would stop the server from starting too, but the ASSERT_DEATH would fail, not sure how to test it. Why do you think it would be better than the CHECK()? -- To view, visit http://gerrit.cloudera.org:8080/16675 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4a446aa8d95a67658c727d3a6f85943d64c79ecf Gerrit-Change-Number: 16675 Gerrit-PatchSet: 6 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 03 Nov 2020 19:44:21 +0000 Gerrit-HasComments: Yes
