Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 )
Change subject: WIP KUDU-2612 C++ client transaction API ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/16710/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16710/4/src/kudu/client/client.h@555 PS4, Line 555: sp::shared_ptr<KuduSession> NewSession(const sp::shared_ptr<KuduTransaction>& txn); Grant suggested to move this under KuduTransaction, which makes more sense, I think. I'll post an update with that change soon. -- To view, visit http://gerrit.cloudera.org:8080/16710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48233f72873012ea36ff4a05d16c58a0ba9b407 Gerrit-Change-Number: 16710 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 12 Nov 2020 22:45:12 +0000 Gerrit-HasComments: Yes
