Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 )
Change subject: WIP KUDU-2612 C++ client transaction API ...................................................................... Patch Set 5: (3 comments) Thank you for the review! It seems I need to add an asynchronous version for committing a transaction :) http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/client/client-internal.h@311 PS5, Line 311: swith > nit: switch Done http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/client/client.h@402 PS5, Line 402: // TODO(aserbin): do we need GetStatus()? > I recall briefly discussing maybe some sort of IsCommitComplete(), or simil Ah, indeed -- we talked about that, but I eventually ended up with only synchronous version of KuduTransaction::Commit(). Thank you for the reminder -- I'll add the async version as well. Right -- as of now, I don't see why we would need to have GetStatus() in this API. And that's a good sign that most likely we don't need that (well, at least at this point). http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/common/txn_id.h File src/kudu/common/txn_id.h: http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/common/txn_id.h@51 PS5, Line 51: int64_t > I might be missing something -- why this change? This is to allow for changes from TxnId with invalid txn_id for a valid one. It's used here https://gerrit.cloudera.org/#/c/16710/5/src/kudu/client/transaction-internal.cc@108 and here https://gerrit.cloudera.org/#/c/16710/5/src/kudu/client/transaction-internal.cc@198 If it makes more sense to separate this into its own changelist, I can do that. -- To view, visit http://gerrit.cloudera.org:8080/16710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48233f72873012ea36ff4a05d16c58a0ba9b407 Gerrit-Change-Number: 16710 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 13 Nov 2020 07:12:32 +0000 Gerrit-HasComments: Yes
