Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16710 )
Change subject: WIP KUDU-2612 C++ client transaction API ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/common/txn_id.h File src/kudu/common/txn_id.h: http://gerrit.cloudera.org:8080/#/c/16710/5/src/kudu/common/txn_id.h@51 PS5, Line 51: int64_t > This is to allow for changes from TxnId with invalid txn_id for a valid one But in both of those changes, txn_id is being set, not txn_id.id_. id_ doesn't appear to be mutated at all, no? -- To view, visit http://gerrit.cloudera.org:8080/16710 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic48233f72873012ea36ff4a05d16c58a0ba9b407 Gerrit-Change-Number: 16710 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 13 Nov 2020 19:19:15 +0000 Gerrit-HasComments: Yes
