Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16858 )
Change subject: [server] add 'uptime' metric for server ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16858/1/src/kudu/server/server_base.h File src/kudu/server/server_base.h: http://gerrit.cloudera.org:8080/#/c/16858/1/src/kudu/server/server_base.h@185 PS1, Line 185: int64_t start_walltime_; Is there a reason you changed the meaning of the original start time instead of defining a new variable for the new time like start_monotime_? http://gerrit.cloudera.org:8080/#/c/16858/1/src/kudu/server/server_base.h@187 PS1, Line 187: monotinic typo? -- To view, visit http://gerrit.cloudera.org:8080/16858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 Gerrit-Change-Number: 16858 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 15:46:04 +0000 Gerrit-HasComments: Yes
