Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16858 )
Change subject: [server] add 'uptime' metric for server ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/16858/1/src/kudu/server/server_base.h File src/kudu/server/server_base.h: http://gerrit.cloudera.org:8080/#/c/16858/1/src/kudu/server/server_base.h@185 PS1, Line 185: int64_t start_walltime_; > That's why this patch required changing all the locations start_time_ was p Ah, I guess the question then was for the naming, right? As for the naming, you can see that elsewhere in the code we don't use walltime, always using either monotime or timestamps. Also, few other objects store MonoTime as start time and have corresponding names for their accessors, for example: * OpDriver::start_time() * Scanner::start_time() This patch just follows the suite. -- To view, visit http://gerrit.cloudera.org:8080/16858 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb362a71c625c05a2185b95ec24d3f371dcb4155 Gerrit-Change-Number: 16858 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 11 Dec 2020 17:27:35 +0000 Gerrit-HasComments: Yes
