Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16868 )
Change subject: [rpc] add slow timing logging for WrapSaslCall ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h@20 PS1, Line 20: #include <sasl/sasl.h> Why does this belong at the top of the file? http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@322 PS1, Line 322: const char* desc) { Should we DCHECK to ensure description isn't null? otherwise "making SASL call" isn't super helpful. http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@323 PS1, Line 323: SCOPED_LOG_SLOW_EXECUTION(WARNING, 100, desc ? desc : "making SASL call"); How did you pick 100ms? -- To view, visit http://gerrit.cloudera.org:8080/16868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f8cff71c35a4aab0307456b1dc4270520966ece Gerrit-Change-Number: 16868 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 14 Dec 2020 04:24:45 +0000 Gerrit-HasComments: Yes
