Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16868 )
Change subject: [rpc] add slow timing logging for WrapSaslCall ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@323 PS1, Line 323: SCOPED_LOG_SLOW_EXECUTION(WARNING, 100, desc ? desc : "making SASL call"); > I think we should error on only logging when it could indicate a larger iss OK, thanks for the clarification. I guess a warning message if the call and lock/unlock take together longer than 250ms should be fine. http://gerrit.cloudera.org:8080/#/c/16868/2/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/2/src/kudu/rpc/sasl_common.cc@324 PS2, Line 324: // In many cases, the GSSAPI SASL plugin will generate a nice error > Is the CHECK_NOTNULL needed given the DCHECK above? It seems this was a remnant from another version. Removed. -- To view, visit http://gerrit.cloudera.org:8080/16868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f8cff71c35a4aab0307456b1dc4270520966ece Gerrit-Change-Number: 16868 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 14 Dec 2020 17:49:23 +0000 Gerrit-HasComments: Yes
