Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16868 )
Change subject: [rpc] add slow timing logging for WrapSaslCall ...................................................................... Patch Set 2: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h@20 PS1, Line 20: #include <sasl/sasl.h> > I think it's possible to move this back, but then we would need to ignore I nah, that's okay. I was just curious why. http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@322 PS1, Line 322: const char* description) { > I was thinking to have more lenient approach to the description, allowing f Given we control all the call sites I think that makes sense. http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@323 PS1, Line 323: DCHECK(description); > 100ms is more than enough for a local call, and it's also long enough for I think we should error on only logging when it could indicate a larger issue or impact Kudu directly. A more conservative 250ms sounds good. http://gerrit.cloudera.org:8080/#/c/16868/2/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/2/src/kudu/rpc/sasl_common.cc@324 PS2, Line 324: SCOPED_LOG_SLOW_EXECUTION(WARNING, 250, CHECK_NOTNULL(description)); Is the CHECK_NOTNULL needed given the DCHECK above? -- To view, visit http://gerrit.cloudera.org:8080/16868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f8cff71c35a4aab0307456b1dc4270520966ece Gerrit-Change-Number: 16868 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 14 Dec 2020 14:52:01 +0000 Gerrit-HasComments: Yes
