Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16868 )
Change subject: [rpc] add slow timing logging for WrapSaslCall ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h File src/kudu/rpc/client_negotiation.h: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/client_negotiation.h@20 PS1, Line 20: #include <sasl/sasl.h> > Why does this belong at the top of the file? That's what IWYU did. I guess it thinks sasl.h belongs to the system-wide libraries. http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc File src/kudu/rpc/sasl_common.cc: http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@322 PS1, Line 322: const char* desc) { > Should we DCHECK to ensure description isn't null? otherwise "making SASL c I was thinking to have more lenient approach to the description, allowing for nullptr. But since you asked, I guess you'd rather see it strict. Done. http://gerrit.cloudera.org:8080/#/c/16868/1/src/kudu/rpc/sasl_common.cc@323 PS1, Line 323: SCOPED_LOG_SLOW_EXECUTION(WARNING, 100, desc ? desc : "making SASL call"); > How did you pick 100ms? 100ms is more than enough for a local call, and it's also long enough for a call to a KDC in a local network. In my test server, it takes about 7ms to get a TGT from the KDC given a keytab. Do you think we should set it to something higher? I guess we might set it to 250ms, or use INFO log here if you are concerned with too much log lines in cluster with somewhat slow KDC. Just in case, I put changed it to 250ms if 100ms seems a bit risky. -- To view, visit http://gerrit.cloudera.org:8080/16868 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f8cff71c35a4aab0307456b1dc4270520966ece Gerrit-Change-Number: 16868 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 14 Dec 2020 06:56:34 +0000 Gerrit-HasComments: Yes
