Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 )
Change subject: [tool] KUDU-2181 CLI to remove master ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc@874 PS7, Line 874: r); > Why don't we have to pass in 'master_to_remove_uuid'? It's not required because there is no ambiguity with other master. I'll add it back for a positive case where uuid isn't strictly necessary. For a case where it's strictly required, need to bring up an ExternalMiniCluster with multiple masters and same HostPort. Might be possible by changing hostname of one of the masters after the cluster is up and but I'm not sure whether ExternalMiniCluster would be able to work. Any idea on how to put an ExternalMiniCluster in a state with 2 masters having the same HostPort but different IPs? -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c97b03475b0ffc7b387d7dfc17acc4b13858fb7 Gerrit-Change-Number: 17010 Gerrit-PatchSet: 7 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 10 Feb 2021 18:40:33 +0000 Gerrit-HasComments: Yes
