Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 )
Change subject: [tool] KUDU-2181 CLI to remove master ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/17010/8/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17010/8/src/kudu/tools/tool_action_master.cc@574 PS8, Line 574: unique_ptr<Action> remove_master = : ActionBuilder("remove", &RemoveMasterChangeConfig) > I suppose it also makes sense to add coverage in kudu-tool-test for this as This too is because of using an outdated branch locally like add CLI. Fixing it. -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c97b03475b0ffc7b387d7dfc17acc4b13858fb7 Gerrit-Change-Number: 17010 Gerrit-PatchSet: 8 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Feb 2021 00:10:34 +0000 Gerrit-HasComments: Yes
