Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 )
Change subject: [tool] KUDU-2181 CLI to remove master ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc@1202 PS9, Line 1202: } Not sure I missed a test I was looking for, but what do you think about adding a test for a use case when first a new master is added mistakenly (say, using a valid, but not intended host), and then rolling back such a change, targeting to run 'kudu add master' again with correct destination node? That's about having a sequence of 'kudu master add <master_rpc_addresses> <new_master_mistaken_address>', immediately followed by 'kudu master remove <master_rpc_addresses> <new_master_mistaken_address>'? -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c97b03475b0ffc7b387d7dfc17acc4b13858fb7 Gerrit-Change-Number: 17010 Gerrit-PatchSet: 9 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Feb 2021 19:06:10 +0000 Gerrit-HasComments: Yes
