Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 )
Change subject: [tool] KUDU-2181 CLI to remove master ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc@874 PS7, Line 874: pda > if the directory is deleted then how will the restarted master become part of > Raft config. I suppose we'd also need to run through the "add master" workflow to do this, which is basically the "recover a master" test case that I suggested at some point. I'm fine merging this as is, provided you're planning on picking that up soon. http://gerrit.cloudera.org:8080/#/c/17010/8/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/17010/8/src/kudu/tools/tool_action_master.cc@574 PS8, Line 574: unique_ptr<Action> remove_master = : ActionBuilder("remove", &RemoveMasterChangeConfig) I suppose it also makes sense to add coverage in kudu-tool-test for this as well? -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c97b03475b0ffc7b387d7dfc17acc4b13858fb7 Gerrit-Change-Number: 17010 Gerrit-PatchSet: 8 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 17 Feb 2021 23:49:39 +0000 Gerrit-HasComments: Yes
