Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 10: (1 comment) > Patch Set 10: > > (1 comment) http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc@1189 PS10, Line 1189: } // namespace master > Initially I was under the impression that all processes (masters, tservers) > have the same hostname/IP and different port numbers to allow running > ExternalMiniCluster tests on a single node but that's not the case. This is dictated by the bind mode so using LOOPBACK instead of UNIQUE_LOOPBACK will help test the scenario which you mention. That impression was because of debugging on Mac OS where the default is LOOPBACK v/s UNIQUE_LOOPBACK elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 10 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Feb 2021 22:22:00 +0000 Gerrit-HasComments: Yes
