Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc@1189 PS10, Line 1189: } // namespace master > Considering LOOPBACK is the default bind mode on Mac OS and been testing wi Yep: I guess adding a new master with the same IP/hostname but different RPC port number should be OK. Just wanted to make sure to be explicit about that use case, and whether we want to artificially disallow that or not. As far as I can see, we should not put any restriction on that, given that it would require _intentionally_ specifying custom port number of a master to run at the same node as an already existing one. So, I guess since we have that LOOPBACK mode for the test, we have everything covered, as needed, right? -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 10 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 19 Feb 2021 00:26:39 +0000 Gerrit-HasComments: Yes
