Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16530/10/src/kudu/master/dynamic_multi_master-test.cc@1189 PS10, Line 1189: } // namespace master > So, I guess since we have that LOOPBACK mode for the test, we have everything > covered, as needed, right? To be clear, we don't have explicit LOOPBACK mode for the test. The test uses the default bind mode which defaults to LOOPBACK on Mac OS and LOOPBACK_UNIQUE elsewhere. -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 10 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 19 Feb 2021 16:58:41 +0000 Gerrit-HasComments: Yes
