Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16530 )
Change subject: [tool] KUDU-2181 CLI to add master ...................................................................... Patch Set 9: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/master/dynamic_multi_master-test.cc@1023 PS9, Line 1023: // Prevent master leadership transfer for a deterministic test. : for (int i = 0 ; i < cluster_->num_masters(); i++) { : // Starting the cluster with following flag leads to a case sometimes : // wherein no leader gets elected leading to failure in ConnectToMaster() RPC. : // So instead set the flag after the cluster is running. : ASSERT_OK(cluster_->SetFlag(cluster_->master(i), "leader_failure_max_missed_heartbeat_periods", : "10.0")); : } nit: does it make sense to separate this into a function/method and use it here and below? http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/master/master_service.cc@275 PS9, Line 275: return; nit: does it make sense to add a LOG(WARNING) or LOG(INFO) about service a "duplicate" request? http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/16530/9/src/kudu/tools/tool_action_master.cc@145 PS9, Line 145: !s.ok() && nit: maybe, drop this part? -- To view, visit http://gerrit.cloudera.org:8080/16530 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I507f301d1aba17327eb35728eed0d765e86ef4cc Gerrit-Change-Number: 16530 Gerrit-PatchSet: 9 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 18 Feb 2021 00:10:51 +0000 Gerrit-HasComments: Yes
