Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17010 )
Change subject: [tool] KUDU-2181 CLI to remove master ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17010/7/src/kudu/master/dynamic_multi_master-test.cc@874 PS7, Line 874: r, > > if the directory is deleted then how will the restarted master become par Tracking that one in KUDU-3249 http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc File src/kudu/master/dynamic_multi_master-test.cc: http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc@380 PS9, Line 380: > style nit: stick the ampersand to the type (i.e. to 'auto') Done http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc@385 PS9, Line 385: master_to_remove != HostPort() > nit: if it makes sense, using !master_to_remove.Initialized() instead might Thanks for pointing this out. Fixed here and above on L355 http://gerrit.cloudera.org:8080/#/c/17010/9/src/kudu/master/dynamic_multi_master-test.cc@1202 PS9, Line 1202: } > Not sure I missed a test I was looking for, but what do you think about add That's a good suggestion but I'd like to keep that combination of addition/removal of masters separate. Filed KUDU-3250. -- To view, visit http://gerrit.cloudera.org:8080/17010 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5c97b03475b0ffc7b387d7dfc17acc4b13858fb7 Gerrit-Change-Number: 17010 Gerrit-PatchSet: 9 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 18 Feb 2021 22:58:09 +0000 Gerrit-HasComments: Yes
