Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 )
Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17388/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17388/1//COMMIT_MSG@7 PS1, Line 7: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job I'm curious whether the motivation behind this ticket is actually to allow users to specify a new database name for new tables. If so, I wonder if it makes sense to parse the current table name, remove the existing database name, and add a user-specified one specified via some flag like --newDatabaseName or somesuch. As is, it seems like this could be used for the same thing, but only by specifying something like --tablePrefix="new_" several times and then renaming tables en masse. http://gerrit.cloudera.org:8080/#/c/17388/1//COMMIT_MSG@10 PS1, Line 10: --tablePrefix option to specify the prefix of the to be resotred table. Similar to the nit: restored http://gerrit.cloudera.org:8080/#/c/17388/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala: http://gerrit.cloudera.org:8080/#/c/17388/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestOptions.scala@56 PS1, Line 56: | --tableSuffix <value> If set, the suffix to add to the restored table names. Only used when createTables is true. nit: maybe put the prefix before suffix? Seems natural, given the prefixes come before suffixes. -- To view, visit http://gerrit.cloudera.org:8080/17388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65adcc1b3de0a8e1ac5b7f50a2d3a7036aa69421 Gerrit-Change-Number: 17388 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 May 2021 18:54:28 +0000 Gerrit-HasComments: Yes
