Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 )
Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job Adding a couple of options of the Kudu Restore job: ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17388/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17388/2//COMMIT_MSG@10 PS2, Line 10: 1.--tablePrefix : Use this option to specify the prefix for a table I am not sure we need both `--tablePrefix` and `newDatabaseName`. If the plan is to add `newDatabaseName`, I think we should drop `--tablePrefix` and just do that. http://gerrit.cloudera.org:8080/#/c/17388/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/17388/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@61 PS2, Line 61: var restoreName = s"${options.tablePrefix}${lastMetadata.getTableName}${options.tableSuffix}" I think it would be a good idea to move the logic to build the restore name into its own function. -- To view, visit http://gerrit.cloudera.org:8080/17388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65adcc1b3de0a8e1ac5b7f50a2d3a7036aa69421 Gerrit-Change-Number: 17388 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 May 2021 02:51:25 +0000 Gerrit-HasComments: Yes
