Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 )
Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17388/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17388/1//COMMIT_MSG@7 PS1, Line 7: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job > My initial motivation for filing the jira was not to support a new database If that's the motivation, the tricky bit with "impala::" still exists, seems like. Let's say we were to have tables pre-HMS integration and we want to restore them: - impala::table1 - impala::default.table2 - table3 - default.table4 The final table names would be the following, and the steps to get there with the restore job only (i.e. no HMS fix tool) are: - default.table1: can't do this right now - default.table2: can't do this right now - default.table3: use the new --tablePrefix option - default.table4: no problems here Perhaps it's worth adding two options then: - --removeImpalaPrefix that just ignores any initial "impala::" in input table names - --newDatabaseName I'm hesitant to add more steps (i.e. altering tables post-upgrade) if we can collapse the process down to a one step with a couple arguments to the tool, especially given it's not just a burden on users, it's potentially significant IO depending on the number of tables that need to be renamed. -- To view, visit http://gerrit.cloudera.org:8080/17388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65adcc1b3de0a8e1ac5b7f50a2d3a7036aa69421 Gerrit-Change-Number: 17388 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 May 2021 19:55:14 +0000 Gerrit-HasComments: Yes
