Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 )
Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job ...................................................................... Patch Set 1: > Patch Set 1: > > Might be confusing to have --tablePrefix and --newDatabaseName. Instead we > could just have --removeImpalaPrefix and --tablePrefix. This would cover all > the previous 4 test cases pointed out by Andrew. Along with that, if the > tables restored pre-HMS sync to post-HMS sync need to be a part of some new > database, that would be facilitated as well: > > Original table > impala::default.testtable > After restore > new_default.testtable > > Thoughts? +1 to having --removeImpalaPrefix. I don't love the idea of only being able to prefix the table name. I think it'd be more useful to be able to specify a new database entirely, and so I'd support --newDatabaseName over --tablePrefix. That said, I'm fine with merging this. I think long term we'll eventually want to add --newDatabaseName though, especially as databases grow to be more of a first class citizen. -- To view, visit http://gerrit.cloudera.org:8080/17388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65adcc1b3de0a8e1ac5b7f50a2d3a7036aa69421 Gerrit-Change-Number: 17388 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 04 May 2021 17:47:34 +0000 Gerrit-HasComments: No
