Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 )
Change subject: [util] Add a function to fetch non-default flags as a map ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@566 PS2, Line 566: vector<CommandLineFlagInfo> nit: Might be worth making 'vector<CommandLineFlagInfo>' a typedef. http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@596 PS2, Line 596: // leading to unexpected value in "flag.name". Not sure I understand this change. The order of the flags could be different due to GetAllFlags? Still don't quite understand how that leads to an unexpected value in 'flag.name'. -- To view, visit http://gerrit.cloudera.org:8080/17400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e7c9fc4de9be05110dba5ca02f48d46b6b474b7 Gerrit-Change-Number: 17400 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 05 May 2021 01:27:00 +0000 Gerrit-HasComments: Yes
