Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 )
Change subject: [util] Add a function to fetch non-default flags as a map ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@566 PS2, Line 566: vector<CommandLineFlagInfo> > nit: Might be worth making 'vector<CommandLineFlagInfo>' a typedef. I don't see a need. http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@581 PS2, Line 581: args.str().empty() > nit: this is not part of this particular patch, but this operation is needl My bad I missed this comment. Will resolve in next change. http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@594 PS2, Line 594: // Instead of "flags_by_name.emplace(flag.name, std::move(flag))" using : // following approach as order of evaluation of parameters could be different : // leading to unexpected value in "flag.name". > Ah, indeed I misinterpreted the comment -- makes sense that we're trying to Done http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@596 PS2, Line 596: // leading to unexpected value in "flag.name". > Ah ok, thanks for the clear explanation. Agreed that this approach is safer Done -- To view, visit http://gerrit.cloudera.org:8080/17400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e7c9fc4de9be05110dba5ca02f48d46b6b474b7 Gerrit-Change-Number: 17400 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 10 May 2021 16:07:35 +0000 Gerrit-HasComments: Yes
