Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17400 )
Change subject: [util] Add a function to fetch non-default flags as a map ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/17400/2/src/kudu/util/flags.cc@581 PS2, Line 581: args.str().empty() > My bad I missed this comment. Will resolve in next change. Not a problem -- this wasn't a part of this patch, so feel free to address it another patch or just ignore :) -- To view, visit http://gerrit.cloudera.org:8080/17400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e7c9fc4de9be05110dba5ca02f48d46b6b474b7 Gerrit-Change-Number: 17400 Gerrit-PatchSet: 2 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Mon, 10 May 2021 16:24:14 +0000 Gerrit-HasComments: Yes
