Bankim Bhavsar has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17400 )
Change subject: [util] Add a function to fetch non-default flags as a map ...................................................................... [util] Add a function to fetch non-default flags as a map We already have a function that returns non-default flags as a vector of strings. This change adds a function that returns non-default flags as a map refactoring and reusing the existing logic. This function is used in add master tool to bring up the new master as it's unnecessary to pass all the flags to the kudu master. This is similar to master run implementation in master_runner.cc. Change-Id: I7e7c9fc4de9be05110dba5ca02f48d46b6b474b7 Reviewed-on: http://gerrit.cloudera.org:8080/17400 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Grant Henke <[email protected]> Reviewed-by: Alexey Serbin <[email protected]> --- M src/kudu/tools/tool_action_master.cc M src/kudu/util/flags.cc M src/kudu/util/flags.h 3 files changed, 40 insertions(+), 21 deletions(-) Approvals: Kudu Jenkins: Verified Andrew Wong: Looks good to me, but someone else must approve Mahesh Reddy: Looks good to me, but someone else must approve Grant Henke: Looks good to me, approved Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/17400 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I7e7c9fc4de9be05110dba5ca02f48d46b6b474b7 Gerrit-Change-Number: 17400 Gerrit-PatchSet: 3 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]>
