Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17391 )

Change subject: wip [txns][tools] show details of a transaction
......................................................................


Patch Set 1:

(1 comment)

Another suggestion is to start using the common "columns" flag.  That will help 
to remove not-so-relevant/deducible columns from the list of default ones, 
allowing to output those, if requested explicitly.

http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc
File src/kudu/tools/tool_action_txns.cc:

http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc@301
PS1, Line 301: show_hybrid_timestamps
Consider using the "columns" flag here.  For a reference, see 
https://github.com/apache/kudu/blob/28a3baab6149ee9317c71a4afc04ad4f3c8da2f9/src/kudu/tools/tool_action_master.cc#L789-L795



--
To view, visit http://gerrit.cloudera.org:8080/17391
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294
Gerrit-Change-Number: 17391
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Wed, 05 May 2021 04:43:51 +0000
Gerrit-HasComments: Yes

Reply via email to