Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17391 )
Change subject: [txns][tools] show details of a transaction ...................................................................... Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc File src/kudu/tools/kudu-txn-cli-test.cc: http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc@187 PS7, Line 187: // Chec > Why not to continue? Ah oops this was left in accidentally, will remove. http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc@196 PS7, Line 196: > transaction Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc File src/kudu/tools/tool_action_txn.cc: http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@127 PS7, Line 127: constexpr c > nit: constexpr const char* const ? Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@138 PS7, Line 138: constexpr c > nit: constexpr const char* const ? Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@204 PS7, Line 204: unknown column specified i > maybe: Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@212 PS7, Line 212: void A > Make this to return void? Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@231 PS7, Line 231: break; : case ListTxnsField::kCommitHybridTime: : col_vals.emplace_back(txn_entry_pb.has_commit_timestamp() ? : HybridClock::StringifyTimestamp(Timestamp(txn_entry_pb.c > Use HybridTimeToDateTime() for this? Done http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@427 PS7, Line 427: > nit: std::move(col_vals) ? Done -- To view, visit http://gerrit.cloudera.org:8080/17391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294 Gerrit-Change-Number: 17391 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 17 May 2021 01:07:46 +0000 Gerrit-HasComments: Yes
