Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17391 )
Change subject: [txns][tools] show details of a transaction ...................................................................... Patch Set 7: (8 comments) http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc File src/kudu/tools/kudu-txn-cli-test.cc: http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc@187 PS7, Line 187: return; Why not to continue? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/kudu-txn-cli-test.cc@196 PS7, Line 196: transction transaction http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc File src/kudu/tools/tool_action_txn.cc: http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@127 PS7, Line 127: const char* nit: constexpr const char* const ? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@138 PS7, Line 138: const char* nit: constexpr const char* const ? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@204 PS7, Line 204: unknown column (--columns) maybe: unknown column specified in --columns ? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@212 PS7, Line 212: Status Make this to return void? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@231 PS7, Line 231: auto physical_micros = HybridClock::GetPhysicalValueMicros(commit_ts); : time_t physical_secs(physical_micros / 1000000); : char buf[kFastToBufferSize]; : commit_ts_date_str = FastTimeToBuffer(physical_secs, buf); Use HybridTimeToDateTime() for this? http://gerrit.cloudera.org:8080/#/c/17391/7/src/kudu/tools/tool_action_txn.cc@427 PS7, Line 427: col_vals nit: std::move(col_vals) ? -- To view, visit http://gerrit.cloudera.org:8080/17391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294 Gerrit-Change-Number: 17391 Gerrit-PatchSet: 7 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sat, 15 May 2021 06:55:52 +0000 Gerrit-HasComments: Yes
