Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17391 )
Change subject: [txns][tools] show details of a transaction ...................................................................... Patch Set 5: (10 comments) http://gerrit.cloudera.org:8080/#/c/17391/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17391/1//COMMIT_MSG@19 PS1, Line 19: ---- > nit: I guess this should change to 'txn' due to the recent changes in the p Done http://gerrit.cloudera.org:8080/#/c/17391/1//COMMIT_MSG@24 PS1, Line 24: 021 19:15:18 GMT | Fr > What is the significance of including this column in the list of default co Done http://gerrit.cloudera.org:8080/#/c/17391/1//COMMIT_MSG@24 PS1, Line 24: Fri, 14 Ma > I'm not sure this should be in the default list of columns: this might be k Done http://gerrit.cloudera.org:8080/#/c/17391/1//COMMIT_MSG@24 PS1, Line 24: 14292843b > Is there a way to output table name/UUID? I guess that's just a convenienc I agree this would be handy. I think it'd also be really nice to show a human-readable version of the partition range/hash values. I think I'll leave a TODO and file a ticket for that once this tool is merged. http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tablet/tablet_metadata.h@331 PS1, Line 331: SetMeta > nit: 'return' is usually used for the return value, maybe extend this a bit Done http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc File src/kudu/tools/tool_action_txns.cc: http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc@76 PS1, Line 76: > warning: using decl 'TxnParticipantEntryPB' is unused [misc-unused-using-de Done http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc@82 PS1, Line 82: > warning: using decl 'SecureShortDebugString' is unused [misc-unused-using-d Done http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc@253 PS1, Line 253: : > Instead, should there be an option to specify which columns to output? As Done http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/tools/tool_action_txns.cc@301 PS1, Line 301: > Consider using the "columns" flag here. For a reference, see https://githu Done http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/transactions/txn_system_client.cc File src/kudu/transactions/txn_system_client.cc: http://gerrit.cloudera.org:8080/#/c/17391/1/src/kudu/transactions/txn_system_client.cc@336 PS1, Line 336: string partition_key; > warning: std::move of the const variable 'p' has no effect; remove std::mov Done -- To view, visit http://gerrit.cloudera.org:8080/17391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cc5c23b6b46ee75e38aaffe4773881a1ece7294 Gerrit-Change-Number: 17391 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 14 May 2021 22:14:37 +0000 Gerrit-HasComments: Yes
