Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17352 )
Change subject: [doc] KUDU-2181 Update multi-master addition/removal/recovery documentation ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@564 PS5, Line 564: master-1,master-2,master-3') nit: not from this change, but would it make sense to have this follow the example we're walking through? I.e. replacing `master-1` with `master1,master-2`? http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@598 PS5, Line 598: Example nit: The example http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@631 PS5, Line 631: UPDATE TABLE_PARAMS I'm curious -- does Impala not do this automatically when performing the alter step above? http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@633 PS5, Line 633: 'master-1.example.com,master-2.example.com,master-3.example.com' : WHERE PARAM_KEY = 'kudu.master_addresses' AND PARAM_VALUE = 'old-master'; nit: not from this change, but would it make sense to have this follow the example we're walking through? I.e. replacing `master-1` with `master1,master-2`? http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@648 PS5, Line 648: /masters nit: not from this patch, but it'd be nice to keep the usage of UI pages consistent -- consider wrapping in backticks? Same elsewhere. http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@703 PS5, Line 703: . On the replacement master It might be worth specifying that, if using the same host, the new master's directories should be empty? Especially for the recovery case, I can imagine users just running through these steps and hitting an error that the catalog already exists. -- To view, visit http://gerrit.cloudera.org:8080/17352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a1d5bc6bbf4bc3e82e7046469d2682bf016d3a8 Gerrit-Change-Number: 17352 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 12 May 2021 19:43:35 +0000 Gerrit-HasComments: Yes
