Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17352 )
Change subject: [doc] KUDU-2181 Update multi-master addition/removal/recovery documentation ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@558 PS5, Line 558: `master-1`, and `master-2` with your a nit: to keep the example consistent, maybe just use `master-1,master-2`? http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@631 PS5, Line 631: UPDATE TABLE_PARAMS > Both the ALTER TABLE and and UPDATE TABLE_PARAMS are almost identical in > terms of updating master addresses. In the former case, tables are updated > individually and in the latter case all the relevant tables are updated at > once. I see, thanks for digging in! Does that mean that we don't need the ALTER TABLE step above? http://gerrit.cloudera.org:8080/#/c/17352/6/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/17352/6/docs/administration.adoc@558 PS6, Line 558: , nit: remove the comma http://gerrit.cloudera.org:8080/#/c/17352/6/docs/administration.adoc@633 PS6, Line 633: 'master-1.example.com,master-2.example.com' nit: not from this change, but let's keep this example consistent and use the `master-1` and `master-2` aliases. -- To view, visit http://gerrit.cloudera.org:8080/17352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a1d5bc6bbf4bc3e82e7046469d2682bf016d3a8 Gerrit-Change-Number: 17352 Gerrit-PatchSet: 6 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 May 2021 18:53:16 +0000 Gerrit-HasComments: Yes
