Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17352 )
Change subject: [doc] KUDU-2181 Update multi-master addition/removal/recovery documentation ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc File docs/administration.adoc: http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@564 PS5, Line 564: master-1,master-2,master-3') > nit: not from this change, but would it make sense to have this follow the I don't get the suggestion. Do you mean replace 'master-1,master-2,master-3' with 'master-1,master-2'? http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@631 PS5, Line 631: UPDATE TABLE_PARAMS > I'm curious -- does Impala not do this automatically when performing the al I don't fully grasp that either and don't know the logic/algorithm used by Impala in determining kudu master addresses for an existing table and creating a new table. My understanding is that the Alter table command above applies to individual already created tables. Though why it's only required for DNS aliases is not clear to me. Again without looking at the Impala/Hive code, --kudu_master_hosts in Impala setting likely translates to populating sys.table_params table in HMS with "kudu.master_addresses". So updating this setting would help in creating new kudu tables henceforth (without per table TBLPROPERTIES) and is equivalent to updating --kudu_master_hosts in Impala and restating it. I don't know whether updating this setting applies to tables already created as I expect Impala to rely on per table TBLPROPERTIES. http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@633 PS5, Line 633: 'master-1.example.com,master-2.example.com,master-3.example.com' : WHERE PARAM_KEY = 'kudu.master_addresses' AND PARAM_VALUE = 'old-master'; > nit: not from this change, but would it make sense to have this follow the Same comment as above. -- To view, visit http://gerrit.cloudera.org:8080/17352 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6a1d5bc6bbf4bc3e82e7046469d2682bf016d3a8 Gerrit-Change-Number: 17352 Gerrit-PatchSet: 5 Gerrit-Owner: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 13 May 2021 22:07:50 +0000 Gerrit-HasComments: Yes
