Bankim Bhavsar has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17352 )

Change subject: [doc] KUDU-2181 Update multi-master addition/removal/recovery 
documentation
......................................................................


Patch Set 6:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc
File docs/administration.adoc:

http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@564
PS5, Line 564: master-1,master-2');
> Yes, sorry for not being clear. This example is all about replacing `master
Done


http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@598
PS5, Line 598: The exa
> nit: The example
Done


http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@631
PS5, Line 631: UPDATE TABLE_PARAMS
Both the ALTER TABLE and and UPDATE TABLE_PARAMS are almost identical in terms 
of updating master addresses. In the former case, tables are updated 
individually and in the latter case all the relevant tables are updated at once.

> Now the question remains the difference between setup with DNS alias and 
> without DNS alias.

I haven't been able to find an answer for this distinction, so I'll keep this 
change as is.


http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@633
PS5, Line 633:   'master-1.example.com,master-2.example.com'
             : WHERE PARAM_KEY = 'kudu.master_addresses' AND PARAM_VALUE = 
'master-1.exa
> Same comment as above.
Done


http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@648
PS5, Line 648: `/master
> nit: not from this patch, but it'd be nice to keep the usage of UI pages co
Done


http://gerrit.cloudera.org:8080/#/c/17352/5/docs/administration.adoc@703
PS5, Line 703: +
> It might be worth specifying that, if using the same host, the new master's
Good point. Added this step in the preparatory steps for replacement master 
above.



--
To view, visit http://gerrit.cloudera.org:8080/17352
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a1d5bc6bbf4bc3e82e7046469d2682bf016d3a8
Gerrit-Change-Number: 17352
Gerrit-PatchSet: 6
Gerrit-Owner: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Bankim Bhavsar <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 14 May 2021 18:02:56 +0000
Gerrit-HasComments: Yes

Reply via email to