Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17388 )
Change subject: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job Adding a couple of options of the Kudu Restore job: ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/17388/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17388/4//COMMIT_MSG@7 PS4, Line 7: [backup] KUDU-3183 Add tablePrefix option to the Kudu restore job : Adding a couple of options of the Kudu Restore job: > nit: put these on the same line I thought the first line was a summary, and the second was the start of the description. We have best practices document linked from https://kudu.apache.org/docs/contributing.html#_submitting_patches : https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines http://gerrit.cloudera.org:8080/#/c/17388/4//COMMIT_MSG@11 PS4, Line 11: This will overwrite any existing : database and if there is no existing database Kudu doesn't have a notion of a database of a standalone entity, so it's a bit strange to read 'existing database'. Also, from this description it's not quite clear what happens with the table olddb.table when --newDatabaseName=newdb: is the olddb.table will be dropped or it will stay along with the newly created newdb.table created by the restore job? -- To view, visit http://gerrit.cloudera.org:8080/17388 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65adcc1b3de0a8e1ac5b7f50a2d3a7036aa69421 Gerrit-Change-Number: 17388 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 20 May 2021 23:02:27 +0000 Gerrit-HasComments: Yes
