Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 )
Change subject: [docker] Add support for publishing UBI based runtime images ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/17564/1/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/Dockerfile@30 PS1, Line 30: ' nit: drop the apostrophe http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@78 PS1, Line 78: : # Targets that use the dev base image. Think it's worth clarifying what makes these "dev" images? Or rather, what make the runtime images "runtime"? Maybe it's obvious, but it'd be good to keep in writing somewhere that the runtime targets require a much lighter-weight environment compared to that required to build Kudu fully. http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@346 PS1, Line 346: if opts.use_ubi: : try: : runtime_base = UBI_MAP[base] : except KeyError: : print('ERROR: --use-ubi is only valid for the following bases: %s' % UBI_MAP.keys()) : sys.exit(1) : print('Runtime images will use UBI image %s...' % runtime_base) To fail a bit faster, maybe move this into its own loop so we exit before doing any building? -- To view, visit http://gerrit.cloudera.org:8080/17564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be121c4ef8422d8aa7556aa163254b43c226b07 Gerrit-Change-Number: 17564 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 08 Jun 2021 22:43:52 +0000 Gerrit-HasComments: Yes
