Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 )
Change subject: [docker] Add support for publishing UBI based runtime images ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/17564/1/docker/Dockerfile File docker/Dockerfile: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/Dockerfile@30 PS1, Line 30: s > nit: drop the apostrophe Done http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@100 PS1, Line 100: --use-ubi > baking* I think UBI is clearly understood as a Red Hat thing. I can add the "runtime" suffix. http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@346 PS1, Line 346: if opts.use_ubi_runtime: : try: : runtime_base = UBI_MAP[base] : except KeyError: : print('ERROR: --use-ubi-runtime is only valid for the following bases: %s' % UBI_MAP.keys()) : sys.exit(1) : print('Runtime images will use UBI image %s...' % runtime_base) > To fail a bit faster, maybe move this into its own loop so we exit before d I am not sure it's really worth it. This serves as both a validation and the way to set the runtime_base for each base. I would end up doing it twice. -- To view, visit http://gerrit.cloudera.org:8080/17564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be121c4ef8422d8aa7556aa163254b43c226b07 Gerrit-Change-Number: 17564 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Bankim Bhavsar <ban...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Jun 2021 14:50:39 +0000 Gerrit-HasComments: Yes
