Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 )
Change subject: [docker] Add support for publishing UBI based runtime images ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@346 PS1, Line 346: if opts.use_ubi: : try: : runtime_base = UBI_MAP[base] : except KeyError: : print('ERROR: --use-ubi is only valid for the following bases: %s' % UBI_MAP.keys()) : sys.exit(1) : print('Runtime images will use UBI image %s...' % runtime_base) > A map check in a for loop is not expensive, and it could save a lengthy hea Done -- To view, visit http://gerrit.cloudera.org:8080/17564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be121c4ef8422d8aa7556aa163254b43c226b07 Gerrit-Change-Number: 17564 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Jun 2021 22:00:35 +0000 Gerrit-HasComments: Yes
