Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17564 )
Change subject: [docker] Add support for publishing UBI based runtime images ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py File docker/docker-build.py: http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@78 PS1, Line 78: : # Targets that use the dev base image. > oh, sorry. I missed this. The definitions of the runtime and dev images are Ack http://gerrit.cloudera.org:8080/#/c/17564/1/docker/docker-build.py@346 PS1, Line 346: if opts.use_ubi_runtime: : try: : runtime_base = UBI_MAP[base] : except KeyError: : print('ERROR: --use-ubi-runtime is only valid for the following bases: %s' % UBI_MAP.keys()) : sys.exit(1) : print('Runtime images will use UBI image %s...' % runtime_base) > I am not sure it's really worth it. This serves as both a validation and th A map check in a for loop is not expensive, and it could save a lengthy headache if a user misconfigures it accidentally, but if you don't think it's worth it that's fine. Also if you do the validation in a separate loop, you don't have to do the try/catch twice. -- To view, visit http://gerrit.cloudera.org:8080/17564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7be121c4ef8422d8aa7556aa163254b43c226b07 Gerrit-Change-Number: 17564 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bankim Bhavsar <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 09 Jun 2021 18:42:29 +0000 Gerrit-HasComments: Yes
