Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17657 )
Change subject: WIP [client] KUDU-2671 flexible partitioning during table creation ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client-test.cc@6895 PS1, Line 6895: This effectively : // cancels the multi-level partitioning defined by the table-wide hash : // partition schema, so the newly added range has no hash sub-partitioning. > Maybe I'm missing it, but isn't this equivalent to calling add_range_partit In my understanding it's not the case, but it's not clearly articulated here. The idea was to provide a means to have a custom range partition with no hash sub-partitioning, even if the table-wide hash partitioning schema assumes there are hash buckets to create for a non-custom range partition. Effectively, in PS1 this isn't yet done as needed: you are right there should be a special way to do so since not specifying a hashing schema for KuduRangePartition leads to the outcome you described, as per implementation of KuduTableCreator::add_range_partition() in this PS1. I guess the code below is missing calling p.add_hash_partitioning({}, 0, 0) or alike. -- To view, visit http://gerrit.cloudera.org:8080/17657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4 Gerrit-Change-Number: 17657 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 08 Jul 2021 20:47:02 +0000 Gerrit-HasComments: Yes
