Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17657 )
Change subject: WIP [client] KUDU-2671 flexible partitioning during table creation ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client.h@1214 PS1, Line 1214: add_hash_partitions(c > nit: maybe call it 'add_hash_partitions()' for consistency with the TableCr Done http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/1/src/kudu/client/client.cc@869 PS1, Line 869: add_custom_range_partition( > nit: I wonder if it makes sense to call this add_custom_range_partition() o Good point: I considered naming it like that, but I rejected it since I thought it was too vague :) From the other side, if we expect KuduRangePartition to be extended with extra fields and be used in other contexts, suddenly 'add_custom_range_partition()' make much more sense. Done. -- To view, visit http://gerrit.cloudera.org:8080/17657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4 Gerrit-Change-Number: 17657 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Fri, 09 Jul 2021 06:00:46 +0000 Gerrit-HasComments: Yes
