Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17657 )
Change subject: [client] KUDU-2671 custom hash buckets API for table creation ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.h@1206 PS4, Line 1206: /// multi-dimensional hash bucket structure for the range partition. > nit: maybe it's worth mentioning that the functionality here isn't complete IIRC, we have similar state for the txn-related stuff before orchestration was ready and didn't annotate anything like that. Anyways, I added corresponding annotation for the KuduTableCreator::add_custom_range_partition() method (I guess just to remove it later on). http://gerrit.cloudera.org:8080/#/c/17657/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/3/src/kudu/client/client.cc@949 PS3, Line 949: This is needed to > nit: unfinished sentence? Done http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc@949 PS4, Line 949: needed to > nit: incomplete? Done http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc@988 PS4, Line 988: a: > nit: missing space Done http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc@272 PS5, Line 272: // key 0 1 2 3 > An earlier iteration mentioned adding a range with no hashing at all. If th Nope, it's not possible to add a hash with only a single bucket. As for the provisions to allow for adding a custom range without any hashing even if the table-wide schema has one, that requires special provisions at the server side: I'm going to address that separately (this test scenario will be updated correspondingly). Overall, I found a few places with some room for improvement, but I'd like to keep this patch to be focused on the API part only (at least that's what I originally thought it would be). -- To view, visit http://gerrit.cloudera.org:8080/17657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4 Gerrit-Change-Number: 17657 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 15 Jul 2021 05:37:35 +0000 Gerrit-HasComments: Yes
