Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17657 )
Change subject: [client] KUDU-2671 custom hash buckets API for table creation ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.h File src/kudu/client/client.h: http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.h@1206 PS4, Line 1206: /// multi-dimensional hash bucket structure for the range partition. nit: maybe it's worth mentioning that the functionality here isn't complete? And this should not yet be used? http://gerrit.cloudera.org:8080/#/c/17657/3/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/3/src/kudu/client/client.cc@949 PS3, Line 949: This is needed to nit: unfinished sentence? http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc File src/kudu/client/client.cc: http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc@949 PS4, Line 949: needed to nit: incomplete? http://gerrit.cloudera.org:8080/#/c/17657/4/src/kudu/client/client.cc@988 PS4, Line 988: a: nit: missing space http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc File src/kudu/client/flex_partitioning_client-test.cc: http://gerrit.cloudera.org:8080/#/c/17657/5/src/kudu/client/flex_partitioning_client-test.cc@272 PS5, Line 272: // key 0 1 2 3 An earlier iteration mentioned adding a range with no hashing at all. If that's not possible, is it possible to have a hash with only a single bucket? -- To view, visit http://gerrit.cloudera.org:8080/17657 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98fd9754db850dcdd00a00738f470673f42ac5b4 Gerrit-Change-Number: 17657 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 14 Jul 2021 23:29:13 +0000 Gerrit-HasComments: Yes
