Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] wip KUDU-2671: Modifies pruning logic to include per range hash schemas. ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17643/1//COMMIT_MSG Commit Message: PS1: > Took a quick look, but what specifically did you think needs to be changed I meant a couple of formatting points outlined in https://git-scm.com/book/en/v2/Distributed-Git-Contributing-to-a-Project#_commit_guidelines There is an example of commit message right there, with its text explaining the principles. Particularly, I meant these two items: * Striving the summary to be 50 characters or less * Wrap lines of the description at 72 characters: as you can see, gerrit shows vertical red dotted line at 72 characters for commit description. -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 20 Jul 2021 16:50:47 +0000 Gerrit-HasComments: Yes
