Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] KUDU-2671: Pruning compatible with custom hash schemas. ...................................................................... Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/17643/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17643/3//COMMIT_MSG@13 PS3, Line 13: : - Adding predicates (e.g. range/equality) : : - Setting lower and upper bound primary keys : : - Setting lower and upper bound partition keys : nit: remove the extra newlines between each bullet? http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition.cc@1147 PS3, Line 1147: for (int i = 0; i < ranges_with_hash_schemas_.size(); i++) { : if (!EqualHashBucketSchemas(ranges_with_hash_schemas_[i].hash_schemas, : rhs.ranges_with_hash_schemas_[i].hash_schemas)) { : return false; : } : } > In addition, does it make sense to compare the lower and the upper boundari +1 http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc File src/kudu/common/partition_pruner-test.cc: http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1056 PS3, Line 1056: tuple<vector<string>, int32_t, uint32_t> nit: consider a typedef for this? Maybe ColumnNamesNumBucketsAndSeed or something http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1100 PS3, Line 1100: auto nit: for pointers, prefer being explicit and use auto* http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1103 PS3, Line 1103: hash_component nit: to avoid any ambiguity with hash_bucket_schemas, maybe call this hash_component_pb so readers can easily infer that one is a protobuf field http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner-test.cc@1103 PS3, Line 1103: auto nit: same here http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner.cc@187 PS3, Line 187: vector<bool> PartitionPruner::PruneHashComponent( Can this and ConstructPartitionKeyRanges() be made static? Or put into the anonymous namespace? http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner.cc@411 PS3, Line 411: Builds nit: let's stick with imperative tense for in-line code comments. I.e. "Build" instead of "Builds", "Store" instead of "Stores", etc. http://gerrit.cloudera.org:8080/#/c/17643/3/src/kudu/common/partition_pruner.cc@509 PS3, Line 509: ForTests() nit: since this isn't only used in tests, remove the "ForTests()" suffix -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Jul 2021 23:03:44 +0000 Gerrit-HasComments: Yes
