Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] wip KUDU-2671: Modifies pruning logic to include per range hash schemas. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17643/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17643/2/src/kudu/common/partition_pruner.cc@435 PS2, Line 435: partition_schema.ranges_with_hash_schemas_.empty() I see this if/else pattern for custom range bounds in multiple places which use PartitionSchema. This isn't a question related to this particular changelist, but since I started looking into addressing some technical debt accumulated in this area: Why not to switch to always using ranges_with_hash_schemas_ in the new code? In other words, why not to always populate ranges_with_hash_schemas_ with appropriate information, even if using table-wide hash schemas for all its range partitions? -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 20 Jul 2021 17:30:39 +0000 Gerrit-HasComments: Yes
