Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17643 )
Change subject: [pruning] KUDU-2671: Pruning compatible with custom hash schemas. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17643/1//COMMIT_MSG Commit Message: PS1: > I meant a couple of formatting points outlined in https://git-scm.com/book/ Done http://gerrit.cloudera.org:8080/#/c/17643/2/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/17643/2/src/kudu/common/partition_pruner.cc@435 PS2, Line 435: partition_schema.ranges_with_hash_schemas_.empty() > I see this if/else pattern for custom range bounds in multiple places which Talked about this offline with Alexey a bit, but will put thoughts here for all to see. I introduced the field `ranges_with_hash_schemas_` with the intention that it would only be populated when a user defines custom hash bucket schemas per range. So in the use case where a user defines multiple range bounds and uses the table wide hash schema then `ranges_with_hash_schemas_` would not be populated as `hash_bucket_schemas` holds the table wide schema. If we were to go away from using `hash_bucket_schemas_` and make the usage of `ranges_with_hash_schemas` ubiquitous, in this use case just described each pair of range bounds would have to be stored and the table wide schema even though it's the same hash schema for each range. My main concern here is storing extraneous data. Basically it comes down to whether or not we want to store per range hash schemas all the time (even if the same hash bucket schema is used for each range). Alexey mentioned using some sort of reference to the hash bucket schema, but I'll let him expand on that if he would like. -- To view, visit http://gerrit.cloudera.org:8080/17643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I05c37495430f61a2c6f6012c72251138aee465b7 Gerrit-Change-Number: 17643 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 22 Jul 2021 00:23:27 +0000 Gerrit-HasComments: Yes
