Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/17725 )
Change subject: KUDU-3204: Add a metric for amount of available space ...................................................................... Patch Set 2: (1 comment) Will take care of the rest of the pointers in the next patch http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt File src/kudu/server/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/17725/2/src/kudu/server/CMakeLists.txt@62 PS2, Line 62: consensus > I'm not sure I understand why this is now required here: server_process is Yes, it is needed to access the flag fs_wal_dir_reserved_bytes which is defined in consensus/log.cc. Wasn't sure getting the flag value through any other means would be more efficient. Any other suggestions to get the flag value? -- To view, visit http://gerrit.cloudera.org:8080/17725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58a7419847d080498aaf431d1dab098e1af71ad0 Gerrit-Change-Number: 17725 Gerrit-PatchSet: 2 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 27 Jul 2021 16:10:32 +0000 Gerrit-HasComments: Yes
